It's nice to see one of these cylinder candy containers that actually appears to be the real deal. This form of candy container has been largely overrun with the fakes currently being cranked out in Germany, being a fairly easy form to fake. (Whenever you see one of these with a slanted hat brim, know that it could have been made yesterday.) From the photos, everything looks supportive of a conclusion that this was made sometime between 1925-1935.
Mark B. Ledenbach's vintage Halloween collectibles blog.